Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support advanced features in radial-gradient #1165 #1167

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Sep 28, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2022

This pull request introduces 3 alerts when merging eb45a78 into a33b350 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

🎊 PR Preview 396bb46 has been successfully built and deployed to https://antvis-G-preview-pr-1167.surge.sh?type=diff&date=2022-09-29

🕐 Build time: 147.074s

🤖 By Surge Ui Insight

@coveralls
Copy link

coveralls commented Sep 28, 2022

Pull Request Test Coverage Report for Build 3148406201

  • 65 of 81 (80.25%) changed or added relevant lines in 6 files are covered.
  • 60 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 75.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/g-lite/src/css/cssom/CSSGradientValue.ts 6 7 85.71%
packages/g-lite/src/css/parser/gradient.ts 33 48 68.75%
Files with Coverage Reduction New Missed Lines %
packages/g-lite/src/css/cssom/CSSGradientValue.ts 1 81.25%
packages/g-lite/src/css/parser/numeric.ts 1 55.88%
packages/g-lite/src/plugins/EventPlugin.ts 3 81.82%
packages/g-lite/src/css/parser/gradient.ts 8 69.96%
packages/g-lite/src/Canvas.ts 12 84.77%
packages/g-lite/src/utils/gradient.ts 35 64.11%
Totals Coverage Status
Change from base Build 3087928092: -0.2%
Covered Lines: 5900
Relevant Lines: 7276

💛 - Coveralls

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2022

This pull request introduces 1 alert when merging 1b954b7 into a33b350 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 29, 2022

This pull request introduces 1 alert when merging 5c26bd8 into a33b350 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

 - @antv/g-camera-api@1.0.7
 - @antv/g-canvas@1.9.6
 - @antv/g-canvaskit@0.8.6
 - @antv/g-compat@1.0.7
 - @antv/g-components@1.7.18
 - @antv/g-css-layout-api@1.0.7
 - @antv/g-css-typed-om-api@1.0.7
 - @antv/g-devtool@0.10.18
 - @antv/g-dom-mutation-observer-api@1.0.7
 - @antv/g-gesture@0.0.41
 - @antv/g-image-exporter@0.5.18
 - @antv/g-layout-blocklike@1.7.18
 - @antv/g-lite@1.0.7
 - @antv/g-lottie-player@0.0.4
 - @antv/g-math@1.7.18
 - @antv/g-mobile-canvas-element@0.6.18
 - @antv/g-mobile-canvas@0.8.15
 - @antv/g-mobile-svg@0.8.15
 - @antv/g-mobile-webgl@0.7.21
 - @antv/g-plugin-3d@1.7.18
 - @antv/g-plugin-a11y@0.4.18
 - @antv/g-plugin-annotation@0.2.15
 - @antv/g-plugin-box2d@1.7.18
 - @antv/g-plugin-canvas-path-generator@1.1.18
 - @antv/g-plugin-canvas-picker@1.8.15
 - @antv/g-plugin-canvas-renderer@1.7.21
 - @antv/g-plugin-canvaskit-renderer@1.1.19
 - @antv/g-plugin-control@1.7.18
 - @antv/g-plugin-css-select@1.7.18
 - @antv/g-plugin-device-renderer@1.7.21
 - @antv/g-plugin-dom-interaction@1.7.18
 - @antv/g-plugin-dragndrop@1.6.18
 - @antv/g-plugin-gpgpu@1.7.18
 - @antv/g-plugin-html-renderer@1.7.18
 - @antv/g-plugin-image-loader@1.1.19
 - @antv/g-plugin-matterjs@1.7.18
 - @antv/g-plugin-mobile-interaction@0.7.18
 - @antv/g-plugin-physx@1.7.18
 - @antv/g-plugin-rough-canvas-renderer@1.7.18
 - @antv/g-plugin-rough-svg-renderer@1.7.18
 - @antv/g-plugin-svg-picker@1.7.18
 - @antv/g-plugin-svg-renderer@1.8.15
 - @antv/g-plugin-webgl-device@1.7.18
 - @antv/g-plugin-webgpu-device@1.7.18
 - @antv/g-plugin-yoga@1.7.18
 - @antv/g-shader-components@1.7.18
 - @antv/g-svg@1.8.15
 - @antv/g-web-animations-api@1.0.7
 - @antv/g-web-components@1.7.18
 - @antv/g-webgl@1.7.21
 - @antv/g-webgpu@1.7.21
 - @antv/g@5.10.0
 - @antv/react-g@1.8.15
 - @antv/g-site@1.8.15
@xiaoiver xiaoiver merged commit 407f5e2 into next Sep 29, 2022
@xiaoiver xiaoiver deleted the feat-lottie branch September 29, 2022 03:20
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 29, 2022

This pull request introduces 1 alert when merging 396bb46 into a33b350 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@xiaoiver
Copy link
Contributor Author

🎉 This PR is included in version @antv/g-gesture-v2.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor Author

🎉 This PR is included in version @antv/g-gesture-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants