fix: the logic boundary condition judgment of text element attribute update is missing (#1755) #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update is missing (#1755)
Aarebecca
approved these changes
Aug 21, 2024
wang1212
added a commit
that referenced
this pull request
Aug 22, 2024
* fix: fix g-react re-render (#1757) * fix: render cache target to avoid rerender * refactor: fix typo of reconciler * fix: the logic boundary condition judgment of text element attribute update is missing (#1755) (#1756) * chore: update changeset * Version Packages (#1758) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Aaron <yangtao.yangtao@antgroup.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixed #1755
💡 Background and solution
see #1755
The solution is to add boundary condition judgment logic. When the number of objects to be updated is 0, the program will jump out directly.
📝 Changelog
☑️ Self Check before Merge