refactor: walkthrough label #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2020 08:44
|
This pull request introduces 1 alert and fixes 3 when merging 2dc96c9 into bdde7f3 - view on LGTM.com new alerts:
fixed alerts:
|
visiky
commented
Nov 6, 2020
| */ | ||
| protected getDefaultOffset(offset: number) { | ||
| protected getLabelOffset(offset: number | string): number { |
There was a problem hiding this comment.
很多处地方都调用了 getDefaultOffset，但实际上并不需要，并且也不是默认 offset；改名为 getLabelOffset, 且在获取 labelCfg 中调用，设置 labelCfg.offset；
labelCfg(用户配置) -> labelOffsetPoint -> labelItem （详细可以看类型定义）
1 task
|
This pull request introduces 1 alert and fixes 3 when merging 91a3c44 into 4dcf6c9 - view on LGTM.com new alerts:
fixed alerts:
|
lessmost
reviewed
Nov 6, 2020
|
This pull request introduces 2 alerts and fixes 3 when merging 81d4c27 into 4dcf6c9 - view on LGTM.com new alerts:
fixed alerts:
|
Pull Request Test Coverage Report for Build 350991689
💛 - Coveralls |
visiky
force-pushed
the
walkthrough-label
branch
from
81d4c27 to
86e4c02
Compare
|
This pull request introduces 2 alerts and fixes 3 when merging 86e4c02 into 4dcf6c9 - view on LGTM.com new alerts:
fixed alerts:
|
visiky
added a commit
to antvis/G2Plot
that referenced
this pull request
Nov 7, 2020
hustcc
reviewed
Nov 7, 2020
hustcc
reviewed
Nov 7, 2020
|
This pull request introduces 2 alerts and fixes 3 when merging f7aeaee into 4dcf6c9 - view on LGTM.com new alerts:
fixed alerts:
|
4 tasks
hustcc
approved these changes
Nov 7, 2020
lessmost
approved these changes
Nov 9, 2020
visiky
added a commit
to antvis/G2Plot
that referenced
this pull request
Nov 9, 2020
hustcc
pushed a commit
to antvis/G2Plot
that referenced
this pull request
Nov 9, 2020
* refactor(docs): 饼图 & 玫瑰图文案和demo走查 * refactor(pie-label): 移除饼图 inner-label 自定义；G2 内置对 string offset 处理 详细：antvis/G2#2981 * docs(pie): 饼图 colorField 为必选,同时显式说明饼图label type有哪些类型 * feat(pie-label): 饼图 label offset 适配，自动根据标签 type 调整 offset * refactor(docs): 文档优化 * refactor(docs): 文档走查 * feat(testcases): 修复单测
jinhuiWong
pushed a commit
to jinhuiWong/G2Plot
that referenced
this pull request
Nov 15, 2020
* refactor(docs): 饼图 & 玫瑰图文案和demo走查 * refactor(pie-label): 移除饼图 inner-label 自定义；G2 内置对 string offset 处理 详细：antvis/G2#2981 * docs(pie): 饼图 colorField 为必选,同时显式说明饼图label type有哪些类型 * feat(pie-label): 饼图 label offset 适配，自动根据标签 type 调整 offset * refactor(docs): 文档优化 * refactor(docs): 文档走查 * feat(testcases): 修复单测
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses修复问题