Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change for JOSS paper #4

Merged
merged 2 commits into from
Nov 30, 2024
Merged

change for JOSS paper #4

merged 2 commits into from
Nov 30, 2024

Conversation

danielskatz
Copy link
Contributor

Summary

Overview

Changes (Check all boxes that apply)

  • Added tests
  • Added examples
  • Updated docs
  • Refactor code
  • Added functionality
  • Fixed bugs (Patch version increase)
  • Changed API (Major/Minor version increase)
  • New release (Major/Minor/Patch version increase)

Checklist

  • All existing tests pass
  • No local merge conflicts
  • Code is commented
  • Tests written for new features (if needed)
  • Version number is updated (if needed)

Optional

Related Github Issues

  • Resolves #

New Dependencies

None

@danielskatz danielskatz mentioned this pull request Nov 30, 2024
Closed
anugrahjo
anugrahjo approved these changes Nov 30, 2024
View reviewed changes
Copy link
Owner

@anugrahjo anugrahjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested changes to the paper look good to me. Approved.

@anugrahjo anugrahjo merged commit 8908a57 into anugrahjo:main Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anugrahjo anugrahjo anugrahjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielskatz @anugrahjo