-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PySLSQP: A transparent Python package for the SLSQP optimization algorithm modernized with utilities for visualization and post-processing #7246
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Dear @hariharanragothaman and @saaikrishnan, please read the first couple of comments in this thread and create your review checklist. You can read the reviewer guidelines here. Also, you can browse the closed "REVIEW" issues on the "joss-reviews" repository to get some ideas on how to complete the reviews. Good luck! |
@prashjha Thanks a lot for the suggestions and guidelines! Will do the needful! ✅ |
Review checklist for @hariharanragothamanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @saaikrishnanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@prashjha Everything looks good to me except for couple of failing tests. Can we please get those fixed ? Thanks |
@saaikrishnan Yes I agree. ✅ There were 2 failing tests. I think this is the reason for it.
Reference:
|
@saaikrishnan I just verified locally that no tests are failing when either of these is followed. You can also see from the GitHub actions page that the tests on the cloud are successful for both the latest commit and the PyPI-released version. Let me know if you have any concerns. Thanks. |
@saaikrishnan @hariharanragothaman |
@anugrahjo Thanks for clarifying and the detailed response. I was wondering if you were in the process of doing a minor / patch release; but this explains! ✅👍 |
@anugrahjo That makes sense! Thank you for the clarification. |
Hi @saaikrishnan and @hariharanragothaman, thank you for your reviews. @saaikrishnan, thank you for giving your recommendation. |
From my end, everything else looks good to me too! Thanks. ✅ |
Hi @hariharanragothaman and @saaikrishnan, could you please check the remaining items on your checklist? Thank you!! |
@editorialbot generate pdf |
@editorialbot generate preprint |
Done! version is now v0.1.2 |
@editorialbot set 10.5281/zenodo.14215102 as archive |
Done! archive is now 10.5281/zenodo.14215102 |
@anugrahjo, I used v0.1.2 instead of 0.1.2 as v0.1.2 matches the tag in your repository. If you want 0.1.2, let me know, and I will change it. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6194, then you can now move forward with accepting the submission by compiling again with the command |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@prashjha v0.1.2 sounds good. |
👋 @anugrahjo - As track chair, I'll next proofread this and let you know if anything else is needed on your part. |
@danielskatz - That sounds good. Thank you for the update! |
@anugrahjo - I'm suggesting a few changes in your paper in anugrahjo/PySLSQP#4 The change to the title is because we don't use special formatting in titles. The changes to the affiliation are because JOSS affiliations are just places, not positions. I also note that this paper is far too long for JOSS. We discussed this when the submission happened, but it doesn't appear that you've addressed it. I suppose this is partially my fault for not enforcing this when the review started. I won't make you do anything about it now. (@prashjha - as a note, you also can enforce shortening papers of this length in the future, even if the track editor forgets.) |
@editorialbot recommend-accept |
|
|
@danielskatz - I have approved and merged the changes in the PR into the main branch. |
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6195, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @anugrahjo (Anugrah Jo Joshy) and co-author on your publication!! And thanks to @hariharanragothaman and @saaikrishnan for reviewing, and to @prashjha for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @anugrahjo (Anugrah Jo Joshy)
Repository: https://github.com/anugrahjo/PySLSQP
Branch with paper.md (empty if default branch):
Version: v0.1.2
Editor: @prashjha
Reviewers: @hariharanragothaman, @saaikrishnan
Archive: 10.5281/zenodo.14215102
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hariharanragothaman & @saaikrishnan, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @prashjha know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @hariharanragothaman
📝 Checklist for @saaikrishnan
The text was updated successfully, but these errors were encountered: