Improve mdx test rule #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I’ve been really happy with mdx. It’s very useful to help stay on top of documentation. I’m looking forward to better dune integration. |
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 18, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 19, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Dec 20, 2019
CHANGES: * Improve mdx test tules (anuragsoni/routes#73, @NathanReb) * Use github actions instead of travis ci (anuragsoni/routes#70, anuragsoni/routes#72) * Get human readable route pattern from a route (anuragsoni/routes#64, anuragsoni/routes#74) * Allow writing custom path match patterns (anuragsoni/routes#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all I'm glad to see a real life user of mdx!
I took the liberty to open a PR to slightly improve the mdx invocation in your dune file as it won't survive the next mdx release!
It was using the
--directionoption which is unnecessary given that option is used for ocaml blocks synchronized with external files and there weren't any such blocks in theREADME.md.I ran into this when trying to release
mdx.1.5.0in which we removed theinfer-timestampdirection as it wasn't working properly. I updated the constraints on themdxdependency so thatroutes.0.5.2can still properly be installed and tested through opam. You can see the release PR over there if you want to know more: ocaml/opam-repository#15415We did that in a minor release because we believed it was unused outside of RealWorldOCaml but it turns out it was here! Sorry for the inconvenience!
I also added a dependency on the
routespackage so thatdune runtestworks from scratch and don't require a previousdune buildso hopefully you'll enjoy that small improvement.We're currently working on a future
2.0.0release ofmdxwith proper integration to dune so that this kind of quirks don't show up again and you won't have to care too much about such CLI options.Let me know what you think!