-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] mdx (1.5.0) #15415
[new release] mdx (1.5.0) #15415
Conversation
CHANGES: #### Added - Add a `--output`/`-o` option to the `test` subcommand to allow specifying a different output file to write the corrected to, or to write it to the standard output (realworldocaml/mdx#194, @NathanReb) - Migrate to OCaml 4.08 AST to add support for `let*` bindings (realworldocaml/mdx#190, @gpetiot) - Add `--syntax` option to `rule` subcommand to allow generating rules for cram tests (realworldocaml/mdx#177, @craigfe) - Add a `require-package` label to explicitly declare dune `package` dependencies of a code block (realworldocaml/mdx#149, @Julow) - Add an `unset-` label to unset env variables in shell blocks (realworldocaml/mdx#132, @clecat) #### Changed - Format rules generated by `ocaml-mdx rule` using `dune format-dune-file` (realworldocaml/mdx#184, @NathanReb) - Run promotion of markdown files before `.ml` files in generated dune rules (realworldocaml/mdx#140, @clecat) #### Fixed - Use module_presence information on Env.summary to prevent fetching absent modules from the toplevel env (realworldocaml/mdx#186, @clecat) - Remove trailing whitespaces at the end of toplevel or bash evaluation lines (realworldocaml/mdx#166, @clecat) - Improve error reporting of ocaml-mdx test (realworldocaml/mdx#172, @Julow) - Rule: Pass the --section option to `test` (realworldocaml/mdx#176, @Julow) - Remove trailing whitespaces from shell outputs and toplevel evals (realworldocaml/mdx#166, @clecat) - Remove inappropriate empty lines in generated dune rules (realworldocaml/mdx#163, @Julow) - Fix ignored `skip` label in `ocaml-mdx pp` (realworldocaml/mdx#1561, @craigfe) - Fix synchronization of new parts from markdown to `.ml` (realworldocaml/mdx#156, @Julow) - Fix ignored `[@@@Parts ...]` markers within module definitions (realworldocaml/mdx#155, @Julow) - Fix a bug in internal OCaml version comparison that lead to crashes in some cases (realworldocaml/mdx#145, @gpetiot) - Promote to empty `.ml` file when using `to-ml` direction (realworldocaml/mdx#139, @clecat) - Apply `--force-output` to `.ml` file as well (realworldocaml/mdx#137, @clecat) - Fix a bug preventing `.corrected` files to be written in some cases (realworldocaml/mdx#136, @clecat) - Add compatibility with `4.09.0` (realworldocaml/mdx#133, @xclerc) #### Removed - Remove the `output` subcommand as it was very specific to RealWorldOCaml needs (realworldocaml/mdx#195, @NathanReb) - Remove the `infer-timestamp` direction (realworldocaml/mdx#171 @Julow)
We did quite some work on the tests so hopefully it should pass the CI builds this time. 🤞 |
I'm looking into the rev deps failures. Some of them are kind of expected and come from bug fixes in |
The failure in |
The The |
Can the rest of the revdeps failure be take care of if I restrict the version of mdx used to |
I'll give a go at fixing the other failures, if it's too much work I'll update the other revdeps myself and will ping you then. Does that sound good to you? |
Ok so I took a deeper look at this and the failure in I'll update the other packages dependencies to fix the issues with whitespaces and will notify package maintainers about this change! |
To sum up:
@kit-ty-kate let me know if that works for you! |
Last comment (sorry I didn't see that sooner) and I think this PR is good to go. |
Co-Authored-By: Kate <kit.ty.kate@disroot.org>
Thanks a lot! |
Executable code blocks inside markdown files
CHANGES:
Added
--output
/-o
option to thetest
subcommand to allow specifying a differentoutput file to write the corrected to, or to write it to the standard output (Add a --output/-o option to specify mdx test output realworldocaml/mdx#194, @NathanReb)
let*
bindings (Migrate to OCaml 4.08 AST realworldocaml/mdx#190, @gpetiot)--syntax
option torule
subcommand to allow generating rules for cramtests (Add support for '--syntax' flag in 'ocaml-mdx rule' realworldocaml/mdx#177, @craigfe)
require-package
label to explicitly declare dunepackage
dependencies of a code block(Specify required packages realworldocaml/mdx#149, @Julow)
unset-
label to unset env variables in shell blocks (Added unset-* label realworldocaml/mdx#132, @clecat)Changed
ocaml-mdx rule
usingdune format-dune-file
(Format dune rules output by rule command realworldocaml/mdx#184, @NathanReb).ml
files in generated dune rules (Changing ocaml-mdx rule diffs order realworldocaml/mdx#140, @clecat)Fixed
toplevel env (Used module_presence type to check if module is in the topevel env realworldocaml/mdx#186, @clecat)
(Trim the end of output realworldocaml/mdx#166, @clecat)
test
(Rule: Print the -s option realworldocaml/mdx#176, @Julow)skip
label inocaml-mdx pp
(realworldocaml/mdx#1561, @craigfe).ml
(Fix parts syncing realworldocaml/mdx#156, @Julow)[@@@parts ...]
markers within module definitions (Fix parts parsing realworldocaml/mdx#155, @Julow).ml
file when usingto-ml
direction (Correcting bug preventing promotion of empty ml files realworldocaml/mdx#139, @clecat)--force-output
to.ml
file as well (Tests may ignore an error if no correction is generated when one was wanted realworldocaml/mdx#137, @clecat).corrected
files to be written in some cases (Removed exit preventing promotion in some cases realworldocaml/mdx#136, @clecat)4.09.0
(Compatibility with 4.09 realworldocaml/mdx#133, @xclerc)Removed
output
subcommand as it was very specific to RealWorldOCaml needs (Remove output subcommand realworldocaml/mdx#195, @NathanReb)infer-timestamp
direction (Remove infer-timestamp direction realworldocaml/mdx#171 @Julow)