forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Disable downstream jobs temporarily #3414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
joncinque
added a commit
that referenced
this pull request
Nov 1, 2024
#### Problem The downstream SPL jobs were disabled in #3414 because the crates weren't being patched properly. #### Summary of changes Since the crates are now being properly patched in solana-labs/solana-program-library#7434, re-enable those jobs! At the same time, remove the patch to bump the curve25519-dalek version.
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
#### Problem The downstream SPL jobs were disabled in #3414 because the crates weren't being patched properly. #### Summary of changes Since the crates are now being properly patched in solana-labs/solana-program-library#7434, re-enable those jobs! At the same time, remove the patch to bump the curve25519-dalek version. (cherry picked from commit f9af09c) # Conflicts: # .github/workflows/downstream-project-spl.yml
joncinque
added a commit
that referenced
this pull request
Nov 1, 2024
…3416) (#3421) * CI: Re-enable downstream SPL jobs (#3416) #### Problem The downstream SPL jobs were disabled in #3414 because the crates weren't being patched properly. #### Summary of changes Since the crates are now being properly patched in solana-labs/solana-program-library#7434, re-enable those jobs! At the same time, remove the patch to bump the curve25519-dalek version. (cherry picked from commit f9af09c) # Conflicts: # .github/workflows/downstream-project-spl.yml * Fix merge conflict --------- Co-authored-by: Jon C <me@jonc.dev>
kevinheavey
pushed a commit
to kevinheavey/agave
that referenced
this pull request
Nov 2, 2024
#### Problem The downstream SPL jobs were disabled in anza-xyz#3414 because the crates weren't being patched properly. #### Summary of changes Since the crates are now being properly patched in solana-labs/solana-program-library#7434, re-enable those jobs! At the same time, remove the patch to bump the curve25519-dalek version.
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Downstream jobs are failing, most likely because the patching script isn't up to date.
Summary of Changes
To quickly unblock CI, just disable the downstream jobs. We'll fixup the patch scripts later
Fixes #