SVM: fix executor metrics accumulation in program loader #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
executor-metrics-fix
branch
from
e6e4fc6 to
bc75dd6
Compare
LucasSte
approved these changes
Nov 19, 2024
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
(cherry picked from commit fa7d553)
buffalojoec
added a commit
that referenced
this pull request
Nov 25, 2024
(cherry picked from commit fa7d553)
buffalojoec
added a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit fa7d553)
buffalojoec
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Program loading is submitting datapoints for the program cache, but it's not accumulating those metrics upstream to the callee's
ExecuteTimings.Summary of Changes
Wire up metrics to SVM's
program_loadermodule and configure SVM as well as Bank to use them properly to accumulate metrics.