v2.1: SVM: fix executor metrics accumulation in program loader (backport of #3695) #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
alessandrod
approved these changes
Nov 25, 2024
|
Backporting since the change is metrics-only, and we definitely want to fix metrics so we can observe 2.1 nodes. |
buffalojoec
force-pushed
the
mergify/bp/v2.1/pr-3695
branch
from
c7f30f2 to
eef95e9
Compare
(cherry picked from commit fa7d553)
buffalojoec
force-pushed
the
mergify/bp/v2.1/pr-3695
branch
from
eef95e9 to
79462f3
Compare
t-nelson
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Program loading is submitting datapoints for the program cache, but it's not accumulating those metrics upstream to the callee's
ExecuteTimings.Summary of Changes
Wire up metrics to SVM's
program_loadermodule and configure SVM as well as Bank to use them properly to accumulate metrics.This is an automatic backport of pull request #3695 done by Mergify.