Backport #3836 ([streamer] Fix musl build) to v2.1 branch #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [streamer] Fix musl build msghdr cannot be directly instantiated on musl due to private padding fields (see rust-lang/libc#2344). The recommended solution is to use `mem::zeroed` to initialize the struct then set the fields as needed. While we could use the same solution for both glibc and musl, we use a conditional compilation directive to avoid using unsafe code when it's not required. * fix lint warnings
Closed
|
BTW: I see v2.1.12 is cut. Is it possible to add this to |
|
HI @jasl - We have some automation that handles backports for us, so I'm going to close this PR. We have cut I added the label to original PR and let automation create the BP PR, cross link: #4642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems the v2.1 branch doesn't include #3836 which will meet trouble when built with MUSL
Summary of Changes
Backport #3836 to the v2.1 branch