v2.1: [streamer] Fix musl build (backport of #3836) #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* [streamer] Fix musl build msghdr cannot be directly instantiated on musl due to private padding fields (see rust-lang/libc#2344). The recommended solution is to use `mem::zeroed` to initialize the struct then set the fields as needed. While we could use the same solution for both glibc and musl, we use a conditional compilation directive to avoid using unsafe code when it's not required. * fix lint warnings (cherry picked from commit 8c1d4f6)
|
Lol I just met this issue, then a PR was created 1min ago that was fast! haha |
|
The possible justification for BP'ing this to v2.1 (extremely late) is that it fixes a compilation issue for musl targets, see the original PR (#3836) for more details. |
|
This is very helpful for building program's Rust client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
msghdr cannot be directly instantiated on musl due to private padding fields (see rust-lang/libc#2344). The recommended solution is to use
mem::zeroedto initialize the struct then set the fields as needed.While we could use the same solution for both glibc and musl, we use a conditional compilation directive to avoid using unsafe code when it's not required.
Summary of Changes
mem::zeroedto initalize themsghdrstruct on musl to avoid issues with private padding fields.This is an automatic backport of pull request #3836 done by [Mergify](https://mergify.com).