This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Release/1.28.0 #11
Merged
Release/1.28.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added matomy as an alias for appnexus * added mobfox adapter * added mobfox adapter * lint fixes in mobfox test * fixed mobfox adapter error handling on invalid json * fixed mobfox adapter error handling on no ad response
* xhb adapter added - use AppNexus test ad unit * adjusted adapter to set responseCPM to 0 and add in dealId * implemented suggested changes * implemented suggested changes * ran jscs fixer for xhb.js and added it to adapters.json * Xhb adapter: adding alias support * minor changes as per request * re-added default bidder settings * Bugfix: getBidRequest was missing utils * minor fix to _defaultBidderSettings
* Removed the one-var lint exclusion, and fixed the existing issues. * Re-fixed the style errors. * Fixed a bug from the unit tests.
* Removed the no-useless-call exclusion. * Fixed an obviously overlooked bug.
* Removed the new-cap lint exclusion. * Removed the exclusion from the test directory as well.
* Added deprecated warnings * Updated deprecated warning message * Added warning messages * Added more info to warning messages * Corrected warning messages
Added sizes: 200x200 and 600x300
* New imonomy Bid Adapter
Adding support of imonomy prebid
test parameters for validating bids
{
bidder: 'imonomy',
params: {
publisher_id: '14567721164'
}
}
contact email of the adapter’s maintainer
tech@imonomy.com
amit@imonmy.com
[X ] official adapter submission
* identetion fixes
fix warning
* add imonomyBidAdapter unit testing
* Fix File Location
+Fix File references
* indentaion on unit test
* more identation fixes
* no-trailing-spaces
* remove jshint
+ fixed all lint isses on adapter
+ replace encode64 with btoa
+ add some more unit tests
* fix - A space is required after ',' comma-spacing
…tests (prebid#1356) * WSAF-4437 Added demographic data support with related unit tests * feature/WSAF-4437 minor fixes: * fixed spelling error in variable name * updated prebid lib version
* Yieldbot adunit bidder params slot name usage fix * Yieldbot adunit bidder params slot name usage fix, PR feedback++
* Fix `documentation lint` issues * Switch JSDoc tags from `property` to `param` * Call param `requestOptions` based on feedback
* priceGranularity should be custom when using custom price bucket * Unit test to check hb_pb when using custom price bucket * removed unwanted comment * updated unit test by testing all price range
* Fixed imports and made adform support aliasing * Fix the broken tests * Renamed _adapter * Updated imports
* implemented AerServ adapter * added unit tests, slight refactor/formatting of adapter code, added to adapters json * implemented AerServ adapter * added unit tests, slight refactor/formatting of adapter code, added to adapters json * feature necromancy! post-merge fixes to account for new structure * last minute addition of some video parameter logic + some name refactoring
A bug was, that the only sizes array would be taken as [[640,480]], not as it is usually given as [640,480]. I fix this.
* Removed deprecated calls. * Replaced some .value() calls with .returns() ones * Fixed all the remaining tests... except for one which was broken. * Updated the yarn lockfile. * Updated to sinon 3.x * Removed the imports-loader, which I didnt actually need. * Commented out another broken test. * Fixed a bunch of errors which were pulled in during the merge. * Better comments on why certain tests were removed.
* added adxcg adapter and associated tests * Removed unnecessary string concatenations and similar utilitiy functions and replaced them with those from prebid utils.js and url.js. Enabled credentials in the ajax call. Replaced string concatenations with template literals where possible. Escaped native click url in order to correctly handle redirects.
…ad (prebid#1555) * Added source and version to request payload * Removed extra code
This reverts commit dc4736a.
…e/Prebid-official-0.27.1 # Conflicts: # modules/aolBidAdapter.js # package.json # src/prebid.js # test/spec/modules/aolBidAdapter_spec.js # test/spec/unit/bidmanager_spec.js # test/spec/unit/pbjs_api_spec.js
…ture/Prebid-official-0.27.1 # Conflicts: # modules/komoonaBidAdapter.js # test/spec/modules/komoonaBidAdapter_spec.js
…rebid-official-0.27.1 to release/1.27.0 * commit 'ed7a85baafff3cade5fc05df1cd2bbadca782463': (98 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) Register bid adapter (prebid#1514) ...
….27.0 to aolgithub-master * commit '5c33711e8d9e543b4a1da00563d78f6d0abd1179': (99 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Updated Komoona bid adapter. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) ...
…e/Prebid-official-0.28.0
….28.0 to aolgithub-master * commit '4d9ade3df767750743f8888ed9efd6c77f8d0050': (26 commits) Added changelog entry. Added new aol partners ids. Prebid 0.28.0 Release Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563) add () for correct order of operations in scaling increments for currency (prebid#1559) AppnexusAst adapter update: Added source and version to request payload (prebid#1555) remove unnecessary spread operator (prebid#1561) Adxcg adapter (prebid#1554) Upgrade sinon to 3.x (prebid#1491) Rename vastPayload to vastXml (prebid#1556) Single-size sizes array now can be taken, too (prebid#1535) Updated the istanbul-instrumenter-loader (prebid#1550) Add AerServ Adapter (prebid#1538) Fixed imports and made adform support aliasing (prebid#1518) Custom granularity fix (prebid#1546) Fix `documentation lint` issues (prebid#1544) Yieldbot adunit bidder params slot name usage fix (prebid#1394) Update serverbid adapter to use smartsync (prebid#1324) Add improvedigitalBidAdapter (prebid#1381) Fix prebid#1533 spring server typo (prebid#1542) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information