Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew jp translation #1290

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Renew jp translation #1290

merged 4 commits into from
Jul 20, 2023

Conversation

tedSw
Copy link
Contributor

@tedSw tedSw commented Jul 18, 2023

Updated and revised the Japanese translation, which had been left untouched for two years.
Added untranslated portions.

tedSw added 3 commits July 14, 2023 15:49
Japanese localize strings update
and un-localized strings to  translation
add new ja-jp translation account
modified name
@aonez aonez self-assigned this Jul 18, 2023
@aonez aonez added this to the 1.3.3 milestone Jul 18, 2023
@tedSw
Copy link
Contributor Author

tedSw commented Jul 18, 2023

do you need iOS translations too?
currently no japanese translation available

Copy link
Owner

@aonez aonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @tedSw! I left you a comment in a pair of strings.

Also can you clarify for me if it's more common to use the space or not use it for example in:

  • Kekaのプロジェクト vs Keka のプロジェクト
  • KekaのアクションをFinderのコンテクストメニューに表示
    Keka のアクションを Finder のコンテクストメニューに表示

I've checked the Safari and VLC Japanese translation and it uses no spaces.

"Encrypt with the default password to..." = "デフォルトのパスワードで暗号化して...";
"Compress to..." = "圧縮先...";
"Compress the contents of the folder here" = "ここにフォルダを圧縮する";
"Compress the contents of the folder to..." = "フォルダを圧縮...";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is important the "contents of the folder" since this action does not compress the folder but its contents. Not sure If the new translation makes it clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the behavior
I'll fix this string soon

@aonez
Copy link
Owner

aonez commented Jul 19, 2023

do you need iOS translations too?
currently no japanese translation available

Sure! You can use the xcloc file (using Xcode) or alternatively the strings files:

https://github.com/aonez/Keka/tree/master/Translations-iOS

You can make a separate pull or update this one if you like.

@tedSw
Copy link
Contributor Author

tedSw commented Jul 20, 2023

Also can you clarify for me if it's more common to use the space or not use it for example in:
I've checked the Safari and VLC Japanese translation and it uses no spaces.

In Japanese translations of Mac APPs, there is a convention of inserting a space between the application name and the translated text.
this practice of inserting spaces is not followed in some applications (such as VLC)

Fix translations that compress the contents of folders
@tedSw tedSw requested a review from aonez July 20, 2023 04:51
@aonez
Copy link
Owner

aonez commented Jul 20, 2023

I did a little more investigation and saw that Safari, Photos and some other macOS apps use no spaces but for example Chromium and Pixelmator uses them. So I'm gonna accept this one.

There's any "rules" page that you know for Japanese translations?

@tedSw
Copy link
Contributor Author

tedSw commented Jul 20, 2023

I did a little more investigation and saw that Safari, Photos and some other macOS apps use no spaces but for example Chromium and Pixelmator uses them. So I'm gonna accept this one.

There's any "rules" page that you know for Japanese translations?

Thanks!
It does not clearly exist as a official document
however, it has been an established rule for Japanese localization for about 20 years.
some translators forget the rules and don't insert spaces (Apple forgets the rules sometimes too)

P.S.
If Apple makes it a policy to not include spaces in the APP name in the Japanese translation across the board, I will update the string accordingly

@aonez aonez merged commit dac8279 into aonez:master Jul 20, 2023
@aonez
Copy link
Owner

aonez commented Jul 20, 2023

Thanks again @tedSw. Here a build in case you can test it: Keka-v1.3.3.r5219

@tedSw
Copy link
Contributor Author

tedSw commented Jul 21, 2023

Thanks again @tedSw. Here a build in case you can test it: Keka-v1.3.3.r5219

test done, there was one string that was not translated, so I added it
sorry about that
no other issues.
thanks!

@tedSw
Copy link
Contributor Author

tedSw commented Jul 24, 2023

@aonez

I trancelating iOS strings now, but...
Translations-iOS/Alternative-Strings-Files/en.lproj/Localizable.strings
is not english strings, this fils contents are in spanish (es)...
can you rewind to english?

there are several places where there are no annotations or it is not clear from the class name what should be expressed

@aonez
Copy link
Owner

aonez commented Aug 7, 2023

Sorry @tedSw for the late reply. I suppose you managed to do it in #1297.

I should improve the script that generates the strings files so the base is all English indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants