Add stuff related to command tags #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggohito
force-pushed
the
feat/synced_command_tags
branch
from
1a04440 to
f4183e8
Compare
+ Added a CCA synced component for command tags; allows for checking for command tags in the client + Added `has_command_tag` entity condition type
eggohito
force-pushed
the
feat/synced_command_tags
branch
from
547c3d7 to
55039e8
Compare
This saves room in the entity's NBT data. Previously, it will create a sub-NBT in the NBT for CCA components, which is pretty bloat-y
eggohito
added
pending: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new entity condition type:
has_command_tag, which checks if an entity has (the specified) command tags. This is also compatible with the fields of eggolib'shas_tagentity condition type.Note
If none of the fields are present, this entity condition type will check if the entity has command tags instead.
command_tagcommand_tagsThis PR also used to add a CCA component,
apoli:command_tags, for storing the entity's command tags, but it has since been removed (in 3/29/2024) in favor of using a data tracker to save on entity NBT data space (it used to store the entity's command tags twice, which was pretty bloaty.)