-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more conditions #205
base: 1.21.x/dev
Are you sure you want to change the base?
Add more conditions #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks:
- The action/condition types should use its own class (most that don't are pretty much old ones). You can use other action/condition types as a reference on how it should look like.
- All things related to command tags (the tags added via the
/tag
command) should already be handled in Add stuff related to command tags #180, so you can remove them in this PR
src/main/java/io/github/apace100/apoli/power/factory/action/EntityActions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/apace100/apoli/power/factory/condition/BlockConditions.java
Outdated
Show resolved
Hide resolved
Just saw this, I will get to work asap, ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fixed!
I am gonna do a quick change to make it so that it also has a comparison condition for the redstone output, aswell as input. Powered condition will be RedstoneInput condition prob aswell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more nitpicks. The others look good to me!
...main/java/io/github/apace100/apoli/power/factory/condition/block/RedstoneInputCondition.java
Outdated
Show resolved
Hide resolved
...main/java/io/github/apace100/apoli/power/factory/condition/block/RedstoneInputCondition.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/apace100/apoli/power/factory/condition/block/RedstoneOutputCondition.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/apace100/apoli/power/factory/condition/block/RedstoneOutputCondition.java
Outdated
Show resolved
Hide resolved
Fixed logic issue with `light_level` block condition type
Fixed! I also added 2 more Conditions I was working on yesterday and forgot to commit, so I applied the changes you requested to those aswell 👍 |
The descriptions for the 2 conditions are in the main comment at the top |
This PR adds a few more entity, item, and block conditions
new Entity Conditions:
new Block Conditions:
new Item Conditions: