Modernize Node.js and build infrastructure #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
modernize-deps
branch
2 times, most recently
from
44aa56c to
6db0bf0
Compare
- Node.js: 10.x/16.x → 22.x LTS (latest stable) - Hugo: 0.58.3/0.91.2 → 0.150.0 (latest version) - Webpack: 4.x → 5.x (major version upgrade) - ESLint: 6.x → 9.x with modern flat config - All dependencies updated to latest stable versions - CI/CD: Updated GitHub Actions to use Node.js 22 - Docker: Updated base image to Debian bookworm + Node.js 22 - Pre-commit: Updated to Node.js 22.13.0 + latest hook versions - Webpack 5: Updated configs for asset modules and modern optimizations - Babel: Simplified config, removed deprecated plugins - ESLint: Migrated to flat config format (eslint.config.js) - Hugo: Fixed template compatibility issues for modern version - Zero vulnerabilities (npm audit clean) - Added package-lock.json for dependency integrity - Modern browser targeting with ES2020+ support - Improved build performance and asset optimization - Updated Hugo templates: .Site.IsServer → hugo.IsServer - Removed deprecated Google Analytics template references - Fixed webpack-dev-server configuration for Webpack 5 All functionality preserved - no user-facing changes expected. Build system fully tested and operational. Comment docker related pre-commits due to outage Fix Hugo 0.135.0 deprecation warnings causing build failure - Issue: languages.en.description on language top level deprecated in Hugo v0.112.0 - Fix: Moved description from [languages.en] to [languages.en.params] - Impact: Follows Hugo multilingual configuration best practices - Issue: .Site.IsServer deprecated in Hugo v0.120.0, removed in v0.136.0 - Fix: Updated remaining instances in theme files: * landing-pages/site/themes/docsy/layouts/partials/scripts.html * landing-pages/site/themes/docsy/layouts/partials/head-css.html - Solution: .Site.IsServer → hugo.IsServer Hugo 0.135.0 (updated in CI) treats these deprecation warnings as hard errors, causing the build to fail with error building site: logged 1 error(s). - ✅ Hugo build: No deprecation warnings or errors - ✅ Full build: Webpack + Hugo pipeline working correctly - ✅ Site generation: 104 pages built successfully
kaxil
force-pushed
the
modernize-deps
branch
from
6db0bf0 to
2ba2926
Compare
kaxil
requested review from
gopidesupavan,
jedcunningham and
potiuk
and removed request for
gopidesupavan
gopidesupavan
approved these changes
Sep 25, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Wow nice, thanks for updating, should we test this on staging branch first?
Member
Author
Yup, that's the plan. And will do that after 3.1.0 release later today |
Member
Author
|
Staging looks good with 90b806f changes @gopidesupavan and I have verified, merging it |
Member
|
Nice! |
kaxil
added a commit
that referenced
this pull request
Oct 30, 2025
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes: 1. Changed p5 import from namespace import to default import - Before: import * as p5 from "p5" - After: import p5 from "p5" 2. Changed CLOSE constant reference from global to sketch instance - Before: sketch.endShape(p5.CLOSE) - After: sketch.endShape(sketch.CLOSE) These changes restore the animated colored squares that appear behind the Apache Airflow header text. Fixes the regression introduced in #1244
kaxil
added a commit
that referenced
this pull request
Oct 30, 2025
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes: 1. Changed p5 import from namespace import to default import - Before: import * as p5 from "p5" - After: import p5 from "p5" 2. Changed CLOSE constant reference from global to sketch instance - Before: sketch.endShape(p5.CLOSE) - After: sketch.endShape(sketch.CLOSE) These changes restore the animated colored squares that appear behind the Apache Airflow header text. Fixes the regression introduced in #1244
kaxil
added a commit
that referenced
this pull request
Oct 30, 2025
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes: 1. Changed p5 import from namespace import to default import - Before: import * as p5 from "p5" - After: import p5 from "p5" 2. Changed CLOSE constant reference from global to sketch instance - Before: sketch.endShape(p5.CLOSE) - After: sketch.endShape(sketch.CLOSE) These changes restore the animated colored squares that appear behind the Apache Airflow header text. Additionally, removed package-lock.json since the project uses yarn (yarn.lock) for dependency management, not npm. Having both lock files can cause conflicts and the CI uses yarn exclusively. The yarn.lock was also regenerated to fix a syntax error that was causing CI failures. Fixes the regression introduced in #1244
kaxil
added a commit
that referenced
this pull request
Oct 30, 2025
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes: 1. Changed p5 import from namespace import to default import - Before: import * as p5 from "p5" - After: import p5 from "p5" 2. Changed CLOSE constant reference from global to sketch instance - Before: sketch.endShape(p5.CLOSE) - After: sketch.endShape(sketch.CLOSE) These changes restore the animated colored squares that appear behind the Apache Airflow header text. Additionally, removed package-lock.json since the project uses yarn (yarn.lock) for dependency management, not npm. Having both lock files can cause conflicts and the CI uses yarn exclusively. The yarn.lock was also regenerated to fix a syntax error that was causing CI failures. Fixes the regression introduced in #1244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Updates
Infrastructure Changes
Build System Modernization
Security & Performance
Template Fixes
All functionality preserved - no user-facing changes expected. Build system fully tested and operational.
Closes: apache/airflow#45620