Fix confetti animation compatibility with p5.js v2.0 #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 30, 2025
kaxil
force-pushed
the
fix-confetti-animation-p5js-v2
branch
from
f78d1ef to
0c19e16
Compare
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes: 1. Changed p5 import from namespace import to default import - Before: import * as p5 from "p5" - After: import p5 from "p5" 2. Changed CLOSE constant reference from global to sketch instance - Before: sketch.endShape(p5.CLOSE) - After: sketch.endShape(sketch.CLOSE) These changes restore the animated colored squares that appear behind the Apache Airflow header text. Additionally, removed package-lock.json since the project uses yarn (yarn.lock) for dependency management, not npm. Having both lock files can cause conflicts and the CI uses yarn exclusively. The yarn.lock was also regenerated to fix a syntax error that was causing CI failures. Fixes the regression introduced in #1244
kaxil
force-pushed
the
fix-confetti-animation-p5js-v2
branch
from
0c19e16 to
3eceae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confetti animation on the landing page header was broken after upgrading to p5.js v2.0 in PR #1244. This fixes two breaking changes:
Changed p5 import from namespace import to default import
Changed CLOSE constant reference from global to sketch instance
These changes restore the animated colored squares that appear behind the Apache Airflow header text.
Fixes the regression introduced in #1244