-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use base aws classes in amazon provider Operators/Sensors/Triggers #35278
Comments
Thanks for getting this set up! |
@Taragolis i am happy to look into this |
@Taragolis I am happy to take EMR, EC2 and S3 (operators) here |
@vincbeck @eladkal Working on this |
Please yes :) |
@gopidesupavan do you plan to address the other Glue services that were left? |
@eladkal Yes will update other services, coming week. |
Body
Right now some inconsistency exists between different Operators/Sensors/Triggers which are use
AwsBaseGeneric
hook.After #34784 and #34884 we could make all of them (except Transfer Operators) use same subset of generic attributes.
It might make more easier to end users use this objects (don't need to think is it
region
orregion_name
or is it even support this arguments), as well as make easier extend by new new hook parameters to all this operators in the one go.General Approach for solve each case:
AwsBaseOperator
for operators,AwsBaseSensor
for sensors. In some very specific case e.g. multi inheritance required to useAwsBaseHookMixin
(see: AppflowRecordsShortCircuitOperator)AwsBaseWaiterTrigger
(if required)All this steps already done for some of the operators, so it could be use as a reference
Committer
The text was updated successfully, but these errors were encountered: