Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Amazon Neptune Hook and Operators #37000

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Adding Amazon Neptune Hook and Operators #37000

merged 10 commits into from
Jan 26, 2024

Conversation

ellisms
Copy link
Contributor

@ellisms ellisms commented Jan 24, 2024

closes #28289

@dirrao dirrao requested a review from Lee-W January 25, 2024 06:58
Lee-W
Lee-W reviewed Jan 25, 2024
View reviewed changes
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/neptune.py Show resolved Hide resolved
eladkal
eladkal reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!
Left some comments then LGTM

airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/neptune.py Outdated Show resolved Hide resolved
@ellisms @eladkal
Update airflow/providers/amazon/aws/operators/neptune.py
c5ea1fc 
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@ellisms
Copy link
Contributor Author

ellisms commented Jan 26, 2024

@eladkal Committed changes for your suggestions. Thanks!

@potiuk
Copy link
Member

potiuk commented Jan 26, 2024

LGTM @Lee-W @Taragolis @eladkal ?

eladkal
eladkal approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladkal eladkal merged commit 004d1d3 into apache:main Jan 26, 2024
55 checks passed
This was referenced Feb 12, 2024
Closed
Closed
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taragolis Taragolis Taragolis left review comments

@Lee-W Lee-W Lee-W left review comments

@potiuk potiuk potiuk approved these changes

@eladkal eladkal eladkal approved these changes

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

Assignees
No one assigned
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AWS Neptune hook and operators
6 participants
@ellisms @potiuk @Taragolis @Lee-W @eladkal @ephraimbuddy