Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit logs entry as clear event even if we click on the tasks. #36119

Closed
1 of 2 tasks
sktemkar16 opened this issue Dec 8, 2023 · 9 comments
Closed
1 of 2 tasks

Audit logs entry as clear event even if we click on the tasks. #36119

sktemkar16 opened this issue Dec 8, 2023 · 9 comments
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@sktemkar16
Copy link

Apache Airflow version

Other Airflow 2 version (please specify below)

What happened

Whenever I click on the task, there is an entry added in the audit logs as task being cleared. This is misleading.
I want the report from the audit logs to check who cleared the tasks from the airflow ui.

Please let me know how to remove this logs. airflow versions - 2.6.1, 2.7.1

What you think should happen instead

The audit logs should not add the entry as clear event by just clicking on the task in the airflow grid.

How to reproduce

Click on any of the executed task in the airflow grid. Go to the audit logs and check the entries to find that it has created a clear event.

Operating System

Linux

Versions of Apache Airflow Providers

2.6.1, 2.7.1

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@sktemkar16 sktemkar16 added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Dec 8, 2023
Copy link

boring-cyborg bot commented Dec 8, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@jscheffl jscheffl added area:UI Related to UI/UX. For Frontend Developers. and removed area:core needs-triage label for new issues that we didn't triage yet labels Dec 20, 2023
@jscheffl
Copy link
Contributor

I can confirm this "problem" and when I open the GRID view for example in example_params_ui_tutorial DAG and then select one task, two additional audit log entries are created:

369 2023-12-20, 21:07:35 example_params_ui_tutorial show_params confirm admin Thor Adminstra [('dag_id', 'example_params_ui_tutorial'), ('dag_run_id', 'manual__2023-12-20T21:05:39+01:00'), ('past', 'false'), ('future', 'false'), ('upstream', 'false'), ('downstream', 'false'), ('state', 'success'), ('task_id', 'show_params')]

368 2023-12-20, 21:07:35 [example_params_ui_tutorial](http://localhost:28080/dags/example_params_ui_tutorial
/graph?execution_date=2023-12-20+20%3A05%3A39%2B00%3A00) show_params clear 2023-12-20, 21:05:39 admin Thor Adminstra [('dag_id', 'example_params_ui_tutorial'), ('dag_run_id', 'manual__2023-12-20T21:05:39+01:00'), ('confirmed', 'false'), ('execution_date', '2023-12-20T20:05:39+00:00'), ('past', 'false'), ('future', 'false'), ('upstream', 'false'), ('downstream', 'true'), ('recursive', 'true'), ('only_failed', 'false'), ('task_id', 'show_params')]

Tracing where it comes it seems the grid-UI calls POST http://server/clear and GET http://server/confirm?...

@bbovenzi Do you know where this is coming from in GRID view? I am a noob (still) in the UI development with Grid.

@Rafnel
Copy link
Contributor

Rafnel commented Jan 2, 2024

My team has also found this issue in 2.6.3. It can definitely cause a scare when trying to figure out what happened in a DAG. Any updates here?

@sktemkar16
Copy link
Author

Yes, it is an issue for us, as we have thousands of DAG's and identifying who cleared the task is very difficult from the audit logs.
Please let me know if this can be fixed or if we have an alternate solution.

cheers!

@jscheffl
Copy link
Contributor

jscheffl commented Jan 3, 2024

Thanks @Rafnel and @sktemkar16 to respond back. Apache Airflow is an open source project, most work consist out of volunteers and only a few "full paid" developers are maintaining. There is no SLA behind fixing bugs or working on it.

If you have a dependency on it feel free to contribute a fix - if you have a commercial interest also it would be fine to hire an consultant or get professional support to contribute a fix. This is how open source software is working. Don't expect people are jumping on all bugs "for free" non-paid.

@potiuk
Copy link
Member

potiuk commented Jan 3, 2024

Yep. Would be great if someone could take that issue and fix it - seems it should be rather simple but to fix one someone debugs and finds the root cause.

@potiuk
Copy link
Member

potiuk commented Jan 3, 2024

So ... volunteers are welcome :)

im-perativa added a commit to im-perativa/airflow that referenced this issue Jan 22, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue apache#36119
@im-perativa
Copy link
Contributor

@potiuk submitted a PR that hopefully can fix this issue

bbovenzi pushed a commit that referenced this issue Jan 22, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119
@jscheffl
Copy link
Contributor

Fixed in #36941

jedcunningham pushed a commit that referenced this issue Feb 9, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
potiuk pushed a commit that referenced this issue Feb 13, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
ephraimbuddy pushed a commit that referenced this issue Feb 22, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

5 participants