Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dryrun autofetch for ClearInstance and MarkInstance #36941

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

im-perativa
Copy link
Contributor

@im-perativa im-perativa commented Jan 22, 2024

this PR set useQuery to be enabled after action button(Clear task/Mark state as) is clicked instead of automatically on render to reduce dry run api calls and prevent unintended audit logs record when clicking task in grid.

closes issue #36119

36941.mp4

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

set useQuery to be enabled after action button is clicked instead of automatically

closes issue apache#36119
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jan 22, 2024
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Do we have test cases for these files. If yes, then can we add the test cases for this change?

@im-perativa
Copy link
Contributor Author

@dirrao I'm not sure if we have test cases for these files as these are UI modification without change to the connexion API. cmiiw

@eladkal eladkal added this to the Airflow 2.8.2 milestone Jan 22, 2024
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jan 22, 2024
@bbovenzi bbovenzi merged commit e0f8c6e into apache:main Jan 22, 2024
52 checks passed
jedcunningham pushed a commit that referenced this pull request Feb 9, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
potiuk pushed a commit that referenced this pull request Feb 13, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
set useQuery to be enabled after action button is clicked instead of automatically

closes issue #36119

(cherry picked from commit e0f8c6e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants