Skip to content

Replace list_jobs with describe_jobs in GlueJobHook #47046

@rawwar

Description

@rawwar

Description

The below comment is from a discussion in a PR: #46950 (comment)

In the Glue hook we implement list_jobs which just calls and returns get_jobs(), but the API has a list_jobs call..... we should maybe look into untangling that. It looks like get_jobs is returning a list of full details for each job, what I would expect to see from a describe_jobs() - which doesn't exist - but the API's version of list_jobs is just returning a list of names, so that would be a breaking change...

IMHO (unless there is some context I'm missing, of course) having hook.conn.list_jobs() return something entirely different than hook.list_jobs() is a bad idea. Maybe we should deprecate our hook.list_jobs() and either rename it hook.describe_jobs() or, preferably, drop it entirely since it's just a thin-wrapper renaming an existing api call. It's a bad habit on our side to rename an existing provider's API feature like that.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions