add startTime to paginator.paginate when fetching logs in GlueJobHook #46950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawwar
commented
Feb 22, 2025
providers/amazon/src/airflow/providers/amazon/aws/hooks/glue.py
Outdated
Show resolved
Hide resolved
…providers/aws/fix_glue_job_verbose
rawwar
force-pushed
the
kalyan/providers/aws/fix_glue_job_verbose
branch
from
9d651dc to
840e309
Compare
2 tasks
ferruzzi
reviewed
Feb 25, 2025
providers/amazon/src/airflow/providers/amazon/aws/hooks/glue.py
Outdated
Show resolved
Hide resolved
ferruzzi
approved these changes
Feb 25, 2025
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Small typo in the comment, but otherwise if this has been manually tested to make sure it actually fixes the issue and the CI finishes green, I think it LGTM.
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
o-nikolas
approved these changes
Feb 26, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
…apache#46950) * add startTime to paginator using startTime from job details Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
67 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…apache#46950) * add startTime to paginator using startTime from job details Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to the issue for a detailed discussion
fixes #44694