The git password/token for GitDagBundle when connecting to Gitlab currently needs to include the token name

[GrumpyCat51]

Apache Airflow Provider(s)

git

Versions of Apache Airflow Providers

apache-airflow-providers-git==0.0.2

Apache Airflow version

3.0.1

Operating System

apache-airflow-providers-git==0.0.2

Deployment

Official Apache Airflow Helm Chart

Deployment details

Running on a local minikube instance

What happened

I setup the GitDagBundle for the dag processor to connect to my Gitlab repository as described in https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/dag-bundles.html with the git connection being defined as

  dag_processor:
    dag_bundle_config_list: '[{"name":"dag-bundle","classpath":"airflow.providers.git.bundles.git.GitDagBundle","kwargs":{"git_conn_id":"git-dags-conn","subdir":"","tracking_ref":"main"}}]'

---

airflow connections add 'git-dags-conn' \
    --conn-type git \
    --conn-login "$GITLAB_TOKEN_NAME" \
    --conn-password "$GITLAB_TOKEN_VALUE" \
    --conn-host 'https://gitlab.com/$GITLAB_USER/$GITLAB_REPO.git'

But when I do this, the dag proc errors out with an 128 error and text message indicating that the authentication failed.
After some trials, I turned out that I had to specify the connection as

airflow connections add 'git-dags-conn' \
    --conn-type git \
    --conn-login "$GITLAB_TOKEN_NAME" \
    --conn-password "$GITLAB_TOKEN_NAME:$GITLAB_TOKEN_VALUE" \
    --conn-host 'https://gitlab.com/$GITLAB_USER/$GITLAB_REPO.git'

and then the dag processor worked as expected.

What you think should happen instead

I should not have to specify the password as TOKEN_NAME:TOKEN_PWD, it should take the provided username

How to reproduce

Create a gitlab repo and a personal token, and insert the settings as decribed above.

Anything else

I did not test this against a Github repository, I can imagine that the behaviour is different there

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[ldacey]

This error was printing my full password in the logs because I did not include the token name in the password field:

cmdline: git clone -v --bare -- https://*****@gitlab.domain.com/airflow.git /tmp/airflow/dag_bundles/gitlab-dags/bare

stderr: 'Cloning into bare repository '/tmp/airflow/dag_bundles/gitlab-dags/bare'...

fatal: could not read Password for 'https://gldt/-@gitlab.domain.com': No such device or address

[codeplatform290]

May I know how did you pass the config in the helm chart. I was working on the same use case with multi git branch.

[GrumpyCat51]

May I know how did you pass the config in the helm chart. I was working on the same use case with multi git branch.

@sushanth2901 I've added the config.dag_processor.dag_bundle_config_list as specified in the "what happened" section above in the config section, and then added the git connection through the cli after connecting to a pod, but you could also specify it through the UI or as an environment variable (https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#storing-connections-in-environment-variables), preferably through a secret that gets added through the corresponding extraEnvFrom field. Or is it something else you have problems with? Happy to help, but I'd probably need more details

[codeplatform290]

Thank you @GrumpyCat51 It worked for me but there are few issues I'm facing.

1. The git i created through UI it didn't work since I'm facing "no host URL found" even though I provided URL. So, I deleted it and created through airflow cli then it worked for me but the problem is few times if dag is restarted or deleted the new pod it not picking up and facing same issue, so i had to create the connection again.