add user_name to http git #51256
add user_name to http git #51256
Conversation
|
Failed test seems not related to the change? |
Rebase to see . |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
| super().__init__() | ||
| connection = self.get_connection(git_conn_id) | ||
| self.repo_url = repo_url or connection.host | ||
| self.user_name = connection.login or "user" |
There was a problem hiding this comment.
@codenamelxl it definitely seems wrong to have a default of "user" for username
why does that make sense?
There was a problem hiding this comment.
This is for the later logic which always enforces a "user_name".
| return | ||
| if self.auth_token and self.repo_url.startswith("https://"): | ||
| self.repo_url = self.repo_url.replace("https://", f"https://{self.auth_token}@") | ||
| self.repo_url = self.repo_url.replace("https://", f"https://{self.user_name}:{self.auth_token}@") |
There was a problem hiding this comment.
what if user is not specified, and you don't want it to be specified?
There was a problem hiding this comment.
The original one does not work for gitlab.
It requires a user_name even for auth_token case.
For github, either no user_name or bogus user_name works.
So I was thinking specifying it like this will achieve the most compatibility. Please refer to: #51256 (comment)
3 participants
closes: #50941
add user_name into http auth link