-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Closed
Labels
area:providersgood first issuekind:featureFeature RequestsFeature Requestsprovider:amazonAWS/Amazon - related issuesAWS/Amazon - related issues
Description
Apache Airflow Provider(s)
amazon
Versions of Apache Airflow Providers
Main
Apache Airflow version
Main
Operating System
Macos
Deployment
Other
Deployment details
No response
What happened
See comment.
The operator EmrCreateJobFlowOperator should follow the same standards as the other operator. All operators in Amazon provider package use the parameter wait_for_completion to configure whether the user wants to wait. However, in EmrCreateJobFlowOperator, this parameter is named wait_policy and is not a boolean but an enum.
What you think should happen instead
- Deprecate the parameter
wait_policy - Add a new parameter
wait_for_completion - Handle both parameters so that it is a non breaking change
How to reproduce
N/A
Anything else
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
area:providersgood first issuekind:featureFeature RequestsFeature Requestsprovider:amazonAWS/Amazon - related issuesAWS/Amazon - related issues