Refactor: deprecate wait_policy in EmrCreateJobFlowOperator in favor of wait_for_completion

[laksh-krishna-sharma]

Summary of changes

Closes #56153

• Deprecated wait_policy parameter in EmrCreateJobFlowOperator.
• Added wait_for_completion (boolean) as the standard parameter (consistent with other Amazon operators).
• Preserved backward compatibility by mapping wait_policy → wait_for_completion.

Changes made

• Refactored constructor logic to prefer wait_for_completion.
• Deprecated wait_policy with warning.

[shahar1]

Could you please add unit tests to ensure that the deprecation works properly?

[laksh-krishna-sharma]

sure @shahar1

[Copilot]

Pull Request Overview

This PR deprecates the wait_policy parameter in EmrCreateJobFlowOperator and replaces it with wait_for_completion to maintain consistency with other Amazon operators while preserving backward compatibility.

• Deprecated wait_policy parameter with a warning message
• Added wait_for_completion boolean parameter as the new standard
• Updated implementation to use wait_for_completion internally with backward compatibility mapping

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
providers/amazon/src/airflow/providers/amazon/aws/operators/emr.py	Updates operator constructor and execute method to use wait_for_completion instead of wait_policy
providers/amazon/tests/unit/amazon/aws/operators/test_emr_create_job_flow.py	Updates test cases to use new parameter and adds deprecation warning test

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[shahar1]

@laksh-krishna-sharma could you please review Copilot's comments and check if they make sense?

[laksh-krishna-sharma]

yes @shahar1 i am reviewing the comments

[laksh-krishna-sharma]

@shahar1 the copilot comments make sense. I’m working on resolving these.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[laksh-krishna-sharma]

@shahar1 Can I mark the above Copilot comments as resolved?

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[shahar1]

@laksh-krishna-sharma please tag me when you're done

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[laksh-krishna-sharma]

@shahar1 please review the changes and let me know if i have to refactor

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[laksh-krishna-sharma]

@shahar1 please review the changes and let me know if i have to refactor

[vincbeck]

One nit but overall looks good!

[laksh-krishna-sharma]

@vincbeck @shahar1 please review the changes and let me know if i have to refactor