Adds missing python-ldap dependency to LDAP extra.

[potiuk]

Please check only the last commit as this is based on #13329

It seems that for quite some time (1.10.4) the "ldap" extra
missed python-ldap dependency.

https://issues.apache.org/jira/browse/AIRFLOW-5261

Also LDAP seems to be popular enough to be added as default
extra in the production image.

Fixes #13306

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[kaxil]

Looks like kerberos and statsd are also missing, can you add them too in this PR and rename it too "Adds missing extra dependencies" ?

[potiuk]

Looks like kerberos and statsd are also missing, can you add them too in this PR and rename it too "Adds missing extra dependencies" ?

Done.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[potiuk]

Hey @kaxil I think this one should succeed :)

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[mik-laj]

Should we add tests to detect if the library has installed correctly? As far as I can see, it has system dependencies, so there is a chance that updating the base image could cause problems that we could easily overlook.

I am thinking of a code similar to the following.

subprocess.run(['docker', '--rm',  $DOCKER_IMAGE, 'python', '-c', 'import ldap'])

[potiuk]

I am thinking of a code similar to the following.

subprocess.run(['docker', '--rm',  $DOCKER_IMAGE, 'python', '-c', 'import ldap'])

I do not see a reason we should treat it differently. If we add it, we should add it for all packages not only for this library - we have plenty of other packages and possibly we should add them all this way. But that should be a separate change where we identify all such libraries and check if they can be imported/used? Maybe just create an issue for it with all such libraries. Maybe you can creat an issue for it ?

UPDATE: I added an issue: #13315

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[potiuk]

Looks like it could be merged :)

[potiuk]

Hey @kaxil - would love to merge it and get the images rebuilt (mostly from scratch for the ldap dependency).

[potiuk]

Should we add tests to detect if the library has installed correctly? As far as I can see, it has system dependencies, so there is a chance that updating the base image could cause problems that we could easily overlook.

I am thinking of a code similar to the following.

subprocess.run(['docker', '--rm',  $DOCKER_IMAGE, 'python', '-c', 'import ldap'])

I rebased the change on top of #13329 which re-enables more comprehensive verification (including checking imports for all added features). I've added LDAP check there.

[potiuk]

Hey @kaxil -> I'd love to merge this one as it changes the image quite significantly at early stage and I wanted to refresh the CI images right after. If you are on holidays, I will merge it with @mik-laj approval - your comments have been applied.

Need upgrading dockerfile with it.