Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables verification of production image #13329

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 27, 2020

Please check only last commit. This commit is based on #13323

The PROD image is now verified by several checks:

  • whether all expected providers are installed
  • whether pip-check shows no conflicts
  • whether imports are working for expected features

Part of #13315


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Dec 27, 2020

@mik-laj -> this PR enables the verification of image as we discussed in #13306 . Depending which one will be merged first we wil add ldap verification here.

@potiuk potiuk force-pushed the enable-production-image-verification branch from 7530736 to 02d2046 Compare December 27, 2020 20:08
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 27, 2020
The PROD image is now verified by several checks:

* whether all expected providers are installed
* whether pip-check shows no conflicts
* whether imports are working for expected features

Part of apache#13315
@potiuk potiuk force-pushed the enable-production-image-verification branch from 573a536 to 90fc9da Compare December 28, 2020 08:00
@potiuk
Copy link
Member Author

potiuk commented Dec 28, 2020

Temporary error. Merging :)

@potiuk potiuk merged commit 3b4290d into apache:master Dec 28, 2020
@potiuk potiuk deleted the enable-production-image-verification branch December 28, 2020 13:02
@potiuk potiuk added this to the Airflow 2.0.1 milestone Jan 2, 2021
kaxil pushed a commit that referenced this pull request Jan 21, 2021
The PROD image is now verified by several checks:

* whether all expected providers are installed
* whether pip-check shows no conflicts
* whether imports are working for expected features

Part of #13315

(cherry picked from commit 3b4290d)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 23, 2021
The PROD image is now verified by several checks:

* whether all expected providers are installed
* whether pip-check shows no conflicts
* whether imports are working for expected features

Part of apache#13315

(cherry picked from commit 3b4290d)
(cherry picked from commit 38b9a41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants