-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The check for image is now more robust #13556
The check for image is now more robust #13556
Conversation
Looks like the response of the API call to check if image is available (retrieving manifest) sometimes returns digest of the image and sometimes it does not :( Example here: https://github.com/apache/airflow/pull/13409/checks?check_run_id=1665801504#step:5:239 Checking for quoted image tag should help. |
🤦 🤦
And sometimes schema 1 answer:
🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 |
Luckily in both cases same error:
|
267c6e0
to
bb4cff3
Compare
Looks red but it's quarantined test. |
The request to get manifest of the image in GitHub Packages might randomly return either schma 1 response: { "schemaVersion": 1, "name": "apache/airflow/master-python3.6-ci", "tag": "470317521", "architecture": "amd64", "fsLayers": [ { Or schema 2 response: { "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "config": { "mediaType": "application/vnd.docker.container.image.v1+json", "size": 56952, "digest": "sha256:5c80e2ab289647802affafc5c1efc879fe4f5b559cb7a2a1215868e84b1d6424" }, In order to check image more reliably we check the status code of the curl response instead.
bb4cff3
to
0de4301
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The request to get manifest of the image in GitHub Packages might randomly return either schma 1 response: { "schemaVersion": 1, "name": "apache/airflow/master-python3.6-ci", "tag": "470317521", "architecture": "amd64", "fsLayers": [ { Or schema 2 response: { "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "config": { "mediaType": "application/vnd.docker.container.image.v1+json", "size": 56952, "digest": "sha256:5c80e2ab289647802affafc5c1efc879fe4f5b559cb7a2a1215868e84b1d6424" }, In order to check image more reliably we check the status code of the curl response instead. (cherry picked from commit dc7d0a6)
The request to get manifest of the image in GitHub Packages might randomly return either schma 1 response: { "schemaVersion": 1, "name": "apache/airflow/master-python3.6-ci", "tag": "470317521", "architecture": "amd64", "fsLayers": [ { Or schema 2 response: { "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "config": { "mediaType": "application/vnd.docker.container.image.v1+json", "size": 56952, "digest": "sha256:5c80e2ab289647802affafc5c1efc879fe4f5b559cb7a2a1215868e84b1d6424" }, In order to check image more reliably we check the status code of the curl response instead. (cherry picked from commit dc7d0a6) (cherry picked from commit 0aaa896)
The request to get manifest of the image in GitHub Packages
might randomly return either schma 1 response:
{
"schemaVersion": 1,
"name": "apache/airflow/master-python3.6-ci",
"tag": "470317521",
"architecture": "amd64",
"fsLayers": [
{
Or schema 2 response:
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"config": {
"mediaType": "application/vnd.docker.container.image.v1+json",
"size": 56952,
"digest": "sha256:5c80e2ab289647802affafc5c1efc879fe4f5b559cb7a2a1215868e84b1d6424"
},
In order to check image more reliably we check the status code
of the curl response instead.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.