Allow custom timetable as a DAG argument #17414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
c6b7684 to
c5b4e99
Compare
uranusjr
changed the title
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
2 times, most recently
from
f693525 to
791ddec
Compare
jedcunningham
approved these changes
Aug 5, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
4 times, most recently
from
fd59fa0 to
f4129d9
Compare
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
3 times, most recently
from
54d5877 to
c1f6815
Compare
Merged
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
c1f6815 to
e1c553c
Compare
ashb
reviewed
Aug 25, 2021
ashb
approved these changes
Aug 25, 2021
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
3 times, most recently
from
c754edc to
74739cd
Compare
|
Static check failing due to unrelated issue. |
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
2 times, most recently
from
bc7ea67 to
d3b56fe
Compare
ashb
reviewed
Aug 30, 2021
| This delegates most of the serialization work to the type, so the behavior | ||
| can be completely controlled by a custom subclass. | ||
| """ | ||
| return {"type": as_importable_string(type(var)), "value": var.serialize()} |
There was a problem hiding this comment.
Possibly __type to match with other "special" keys? Not sure
There was a problem hiding this comment.
I’m assuming we’re not yet set on the serialisation method because of the class registration stuff (and I’m not sure the current method will always work if the timetable class is declared in a DAG file), so let’s not think too hard on this for now?
ashb
approved these changes
Aug 30, 2021
All existing aceess to schedule_interval (the normalized property is not used anywhere) are all changed to use the DAG's timetable member. A couple of timetable-describing flags, can_run and periodic, are added to replace some usages that need to know about what the timetable is capable of doing. Serialization methods are added to timetable classes so the timetable can be saved to the meta database during DAG serialization.
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
d3b56fe to
138defd
Compare
|
Registration issue opened as #17931. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow a custom
timetableargument to work on a DAG, the existingschedule_intervalattribute and thenormalized_schedule_intervalproperty are removed. All existing aceess toschedule_interval(the normalizedproperty is not used anywhere) are all changed to use the DAG's
timetablemember. A couple of timetable-describing flags,can_runandperiodic, are added to replace some usages that need to know about what the timetableis capable of doing.
Serialization methods are added to timetable classes so the timetable can be saved to the meta database during DAG serialization.
Since the
schedule_intervalattribute has been removed, the field onDagModelof the same name is also changed. Since we still need that information to display the timetable on the web UI,timetable.summaryis used to “backfill”schedule_intervalif a custom timetable is used.schedule_intervalbecomes purely cosmetic and only used to UI display.