fix(timetable): CronMixin issue when DST #35632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #35558.
This is an attempt to figure out how the
CronMixin
class was working, and especially_get_prev
and_get_next
methods.By making timezone aware the
scheduled
variable in the two methods, I managed to suppress the issue. Therefore, I am questioning the two methods logic (which I still didn't figure out). I found the introduction of those two methods in #17414 (Hello @uranusjr 👋 ). Do we really need to compute thedelta
withscheduled
andnaive
variables? This is error prone since, during a DST, the delta will not be coherent? If I am missing something, I think we would really benefit from documentation + tests on those two methods.###$ Before my changes:
After them
We notice that the the value are coherent in the second batch
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.