Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace days ago #21830

Closed
wants to merge 2 commits into from
Closed

Replace days ago #21830

wants to merge 2 commits into from

Conversation

Dev232001
Copy link
Contributor

Replaced all datetime.datetime() functions with pendulum.datetime() where start dates are included.

@potiuk
Copy link
Member

potiuk commented Feb 28, 2022

I think in all those tests, we should also explicitly add catchup=False. Not sure what defaults are set in the tests , but since it can be changed by configuration it makes perfect sense to add catchup=False explicitly

Explicit is better than implicit!

@Dev232001
Copy link
Contributor Author

Can you do that in another issue for now as I will not be available for a week due to an internship program that I am currently working in. This is my last week of internship and I have to submit the project by 7 March

@potiuk
Copy link
Member

potiuk commented Mar 6, 2022

Can you do that in another issue for now as I will not be available for a week due to an internship program that I am currently working in. This is my last week of internship and I have to submit the project by 7 March

It can wait for you to return, there is no hurry.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 21, 2022
@github-actions github-actions bot closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants