Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of days_ago() from test suite #23233

Closed
1 task done
eladkal opened this issue Apr 25, 2022 · 3 comments · Fixed by #23237
Closed
1 task done

Remove usage of days_ago() from test suite #23233

eladkal opened this issue Apr 25, 2022 · 3 comments · Fixed by #23237
Labels
good first issue kind:task A task that needs to be completed as part of a larger issue

Comments

@eladkal
Copy link
Contributor

eladkal commented Apr 25, 2022

Body

days_ago() is deprecated #21653

There are many test using this function thus raising warnings.
This task is to replace all usages of days_ago() in the tests with alternatives.
A stale PR that started to work on it #21830 but didn't finish

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added good first issue kind:task A task that needs to be completed as part of a larger issue labels Apr 25, 2022
@uranusjr uranusjr mentioned this issue Apr 25, 2022
Merged
@eladkal eladkal mentioned this issue May 29, 2022
Closed
1 task
@maryampashmi
Copy link

What we should use instead of days_ago()?

@potiuk
Copy link
Member

potiuk commented May 12, 2023

What we should use instead of days_ago()?

Fixed date when your DAG's beginning of life is. Pick a date that you either created it or one that you might ever want to backfill from). Using days_ago used to be present in our examples erroneously but never had any sense.

@potiuk
Copy link
Member

potiuk commented May 12, 2023

Just look at our examples NOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced all days_ago functions with datetime functions astronomer/airflow
3 participants
@potiuk @maryampashmi @eladkal