-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all usages of days_ago from test suite #21683
Comments
Hi, can i take it? |
@hubert-pietron sure, assigned to you. |
Hi, can you assign this to me? |
Just check with @hubert-pietron - if it's not something already started. |
Let me know @Dev232001 how you want to split, or you can take whole and i will look for another issue to work on :) |
Hi @hubert-pietron , thanks for letting me join this issue here. I am relatively new to open source contributions and was looking for a beginner level task. This looked like an easy problem so I asked for this. If you can just give me an update on what you have done till now that will be the best. I think I will be able to work on the rest of the issue from thereon :) |
https://github.com/apache/airflow/tree/main/airflow/example_dags |
it can be in example dags or in tests. |
Okay. Appreciate the help. Thanks
…On Wed, Feb 23, 2022, 10:36 PM eladkal ***@***.***> wrote:
it can be in example dags or in tests.
You can find all references by searching airflow.utils.dates import
days_ago in the code base.
—
Reply to this email directly, view it on GitHub
<#21683 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXEWNKGB3OWNKGQ3MGINIJ3U4UHZHANCNFSM5O2LUIXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I just looked how many occurrences there is in code, so You can take it all :) |
I have completed the given task and created a pull request for the same. Kindly review it. tests - decorators - test_python_virtualenv.py - errors found tests - operators - test_python.py - import funcsigs - error |
This is my first contribution and its asking for a approval review |
`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683
`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683
`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683
Body
days_ago
is deprecated #21653We have several references to the function in test suite / example dags.
Task:
there should be no imports of
airflow.utils.dates import days_ago
in the code.In most cases we can simple replace with
datetime(2022, 1, 1)
Committer
The text was updated successfully, but these errors were encountered: