Deprecate helper utility days_ago
#21653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
approved these changes
Feb 18, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
This helper function is not all that helpful, introduces confusion (e.g. which timezone? how to handle DST?), and results in a "moving" start date for dags. Vote thread: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk
dstandish
force-pushed
the
deprecate-days-ago
branch
from
2a428b3 to
be5cc1f
Compare
eladkal
approved these changes
Feb 18, 2022
1 task
|
And here is why this was a GREAT move to deprecate days_ago: #10824 (comment) |
ephraimbuddy
added
the
type:misc/internal
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper function is not all that helpful, introduces confusion (e.g. which timezone? how to handle DST?), and results in a "moving" start date for dags.
Vote thread: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk