-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mapped task immutability after clear #23667
Fix mapped task immutability after clear #23667
Conversation
2da46f7
to
60c2445
Compare
Ready for review while I add the remaining test |
25eb2a8
to
4ea8eda
Compare
This needs some docstrings and comments to explain why and when the logic is needed and what do they do. |
57932c4
to
ac09bac
Compare
I have refactored the code. Please take a look #24114 |
be39a17
to
084dc7e
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
e82e9e4
to
b1a290a
Compare
Seems there's a flaky test:
Will look at it later |
It's Postgres 14 each time (whereas pg10 passes) so it's possibly some quirk in return format? Or it is exposing a bug :) |
b1a290a
to
0c54f3a
Compare
0c54f3a
to
8baedbe
Compare
We should be able to detect if the structure of mapped task has changed and verify the integrity. This PR is an attempt to fix it
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
8baedbe
to
73af4b2
Compare
We should be able to detect if the structure of mapped task has changed and verify the integrity. This PR ensures this Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit b692517)
We should be able to detect if the structure of mapped task has changed
and verify the integrity.
This PR is an attempt to do that
Closes: #23550