Refactor DagRun.verify_integrity
#24114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
force-pushed
the
refactor-verify-integrity
branch
from
a01a033
to
9f1220b
Compare
|
I think it'd be helpful if the commit/PR explained why this refactor is a good idea/needed as groundwork. |
ephraimbuddy
force-pushed
the
refactor-verify-integrity
branch
from
9f1220b
to
7aaea5c
Compare
norm
approved these changes
Jun 8, 2022
Thanks. I have updated it |
ephraimbuddy
force-pushed
the
refactor-verify-integrity
branch
2 times, most recently
from
161a15c
to
ac3b7d3
Compare
dstandish
approved these changes
Jun 9, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
force-pushed
the
refactor-verify-integrity
branch
from
b5cd303
to
0c474a8
Compare
uranusjr
approved these changes
Jun 10, 2022
This refactoring became necessary as there's a necessity to add additional code to the already exisiting code to handle mapped task immutability during run. The additional code would make this method difficult to read. Refactoring the code will aid understanding and help in debugging.
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
ephraimbuddy
force-pushed
the
refactor-verify-integrity
branch
from
0c474a8
to
40c7798
Compare
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
added a commit
that referenced
this pull request
Jun 29, 2022
This refactoring became necessary as there's a necessity to add additional code to the already exisiting code to handle mapped task immutability during run. The additional code would make this method difficult to read. Refactoring the code will aid understanding and help in debugging. (cherry picked from commit 12638d2)
ephraimbuddy
added
type:misc/internal
This was referenced Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring became necessary as there's a necessity to add additional code
to the already exisiting code to handle mapped task immutability during run. The additional
code would make this method difficult to read. Refactoring the code will aid understanding and
help in debugging.