Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <2.0.0 limit on google-cloud-bigtable #29644

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Remove <2.0.0 limit on google-cloud-bigtable #29644

merged 6 commits into from
Feb 22, 2023

Conversation

r-richmond
Copy link
Contributor

@r-richmond r-richmond commented Feb 20, 2023 •
edited
Loading

related: #27292
related: #26922

What this does

  • Removes <2.0.0 limit on google-cloud-bigtable and corresponding protobuf limit

Why

  • python 3.11 support
  • the corresponding protobuf limit restricted multiple other packages from later versions
    • Of interest to me it limited google-cloud-aiplatform to 1.13.1
    • which limited google-cloud-bigquery to >=1.15.0,<3.0.0dev
  • Only 1 non-significant breaking change in google-cloud-bigtable 2.0+

Update

  • Updated pr to account for Enum import path moving slightly and type changes

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Feb 20, 2023
@uranusjr
Copy link
Member

ImportError: cannot import name 'enums' from 'google.cloud.bigtable_admin_v2'

Looks like there are incompatibilities.

@r-richmond
Copy link
Contributor Author

Looks like there are incompatibilities.

Yep, looks like the release notes weren't as truthful this time.. I'll see if I can I fumble my way through this bit later today. (Little difficult on my end since I don't actually use big table just big query but 🤷 )

@eladkal eladkal mentioned this pull request Feb 20, 2023
Closed
13 tasks
@r-richmond
Copy link
Contributor Author

@uranusjr think I got everything. Last test failed due to 2 hour queue timeout.

@potiuk
Copy link
Member

potiuk commented Feb 21, 2023

@uranusjr think I got everything. Last test failed due to 2 hour queue timeout.

Yeah - we had some "blocked" build queue - I unblocked it now. Rebasing to re-run.

@r-richmond
Copy link
Contributor Author

r-richmond commented Feb 21, 2023 •
edited
Loading

Latest failure looks like another pipeline issue unrelated to this change

/home/runner/work/_temp/5e427642-8610-4b5e-8e04-24f61c20032d.sh: line 1: 4290 Killed breeze testing tests --run-in-parallel
371

@r-richmond
Copy link
Contributor Author

This hit the same error that my local run of find newer dependencies did. Not sure what to do from here..

@r-richmond r-richmond mentioned this pull request Feb 22, 2023
Closed
2 tasks
@uranusjr uranusjr mentioned this pull request Feb 22, 2023
Merged
@uranusjr
Copy link
Member

The error is from a bug in our CI setup code. I opened a PR (linked above) to fix it.

@potiuk
Copy link
Member

potiuk commented Feb 22, 2023

Nice. That one brings us much closer to Python 3.11 support.

@potiuk potiuk merged commit ad08f66 into apache:main Feb 22, 2023
@potiuk
Copy link
Member

potiuk commented Feb 22, 2023

The error is from a bug in our CI setup code. I opened a PR (linked above) to fix it.

Thanks @uranusjr ! That was a bummer :)

@r-richmond r-richmond deleted the bump-google-cloud-bigtable branch February 22, 2023 16:00
@r-richmond r-richmond mentioned this pull request Feb 22, 2023
Closed
2 tasks
@eladkal eladkal mentioned this pull request Mar 3, 2023
Closed
40 tasks
@r-richmond r-richmond mentioned this pull request Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:providers kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-richmond @uranusjr @potiuk