feat!: microgenerator changes #203
Conversation
…generator-changes
…icrogenerator-changes
…icrogenerator-changes
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
|
Here is the summary of changes. You added 1 region tag.
You deleted 1 region tag.
This comment is generated by snippet-bot.
|
| max_age = _helpers._duration_pb_to_timedelta(gc_rule_pb.max_age) | ||
| return MaxAgeGCRule(max_age) | ||
| # todo check this is right | ||
| # max_age = _helpers._duration_pb_to_timedelta(gc_rule_pb.max_age) |
There was a problem hiding this comment.
question - is this change the correct new approach?
There was a problem hiding this comment.
This might be good to dig into. protoplus knows timestamps, and I would expect gc_rule_pb.max_age to be one, without the helper? Though timedelta isn't timestamp and I don't recall offhand if that is implemented. to be safe, I'd expect gc_rule_pb._pb.max_age to allow the other code to stay the same?
…icrogenerator-changes
kolea2
added
the
do not merge
google/cloud/bigtable/table.py
Outdated
| @@ -1071,10 +1087,11 @@ def _do_mutate_retryable_rows(self): | |||
| if self.timeout is not None: | |||
| kwargs["timeout"] = timeout.ExponentialTimeout(deadline=self.timeout) | |||
|
|
|||
| # todo confirm this change | |||
There was a problem hiding this comment.
@crwilcox another todo I missed - I think my concern here was the mutate rows call wasn't wrapped in a request={... but I think due to the code below this (will need to expand) this works as expected. LMK if you have a concern
| bigtable_table_admin_client_config as table_admin_config, | ||
| ) | ||
|
|
||
| # from google.cloud.bigtable_admin_v2.gapic import ( |
| bigtable_table_admin_pb2.ListBackupsRequest( | ||
| parent=parent, filter=backups_filter, **kwargs | ||
| ), | ||
| retry=mock.ANY, |
There was a problem hiding this comment.
@crwilcox one last thing to point out - the last few params were now removed from the assertion because we are no longer using the inner_api_calls to get the result, let me know if oyu think this should still be here.
kolea2
removed
the
do not merge
* ci: run samples under Python 3.9 / 3.10
Refresh each sample's noxfile via:
----------------------------- %< -----------------------------
$ for noxfile in samples/*/noxfile.py; do
echo "Refreshing $noxfile";
wget -O $noxfile https://github.com/GoogleCloudPlatform/python-docs-samples/raw/main/noxfile-template.py
echo "Blackening samples for $noxfile"
nox -f $noxfile -s blacken
done
----------------------------- %< -----------------------------
Closes #477.
* fix: disable install-from-sorce for beam sample
Per #203.
* fix: skip beam sample for Python 3.10
Beam-related wheels are not yet available.
* fix: also refresh noxfiles for 'samples/snippets'
* ci: don't enforce type hints on old samples
* resolve issue where samples templates are not updated
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* resolve mypy error Name __path__ already defined
* add workaroud from PR #203
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Release-As: v2.0.0-dev1
Regen the client with the microgenerator. This requires the client to be used with Python >= 3.6
There are a few outstanding questions I have that I will annotate in the PR. Most important changes to pay attention to are the handwritten client and test layers.