-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop through paginated response to check for cluster id #29732
Conversation
You could mock this method and use side_effect |
@nsAstro I am not a codeowner, you'll need one of @eladkal @o-nikolas to review. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Hey @nsAstro! Any status update on this one? Seems like just a few small outstanding feedbacks. |
It doesn't look like @nsAstro is enganged on this one any more. I'll push the remaining fixes if I get some time in the next few days. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
- Separate tests into individual methods - Ensure pagination test checks for cluster id on second page
I updated the PR to address the remaining feedback |
unexpected ident does not signal anything good. |
Fix indent
Ooop! I updated @nsAstro's PR through the Github UI text editor (which has no bells and whistles for linting or catching those indents) so I missed that one! Hopefully that stops the build from timing out 😁 |
Loops through the paginated emr list_clusters endpoint and searches each set for the given cluster_id.
closes: #29712