Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop through paginated response to check for cluster id #29732

Merged
merged 16 commits into from
May 1, 2023
Merged

Loop through paginated response to check for cluster id #29732

merged 16 commits into from
May 1, 2023

Commits on Mar 12, 2023

  1. Loop through paginated response to check for cluster

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    953a58b View commit details
    Browse the repository at this point in the history

  2. Use Boto pagination

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    c35af44 View commit details
    Browse the repository at this point in the history

  3. Remove case for old pagination marker

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    ec95e54 View commit details
    Browse the repository at this point in the history

  4. Add test case using Moto to test for 51 clusters list as well as dupl… 

    …icated name
    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    a2a10e3 View commit details
    Browse the repository at this point in the history

  5. Fix test and correct function logic to use page instead of response

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    037eac4 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    c82cec3 View commit details
    Browse the repository at this point in the history

  7. Fix tests and force case for second page EMR cluster

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    4546f16 View commit details
    Browse the repository at this point in the history

  8. Formatting

    @potiuk
    Nakkul Sreenivas authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    b275f87 View commit details
    Browse the repository at this point in the history

  9. Merge lines to improve readability 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @nsAstro @uranusjr @potiuk
    2 people authored and potiuk committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    5679b29 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Update tests/providers/amazon/aws/hooks/test_emr.py 

    Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @o-nikolas @uranusjr
    o-nikolas and uranusjr authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7b92c8f View commit details
    Browse the repository at this point in the history

  2. Address PR Feedback 

    - Separate tests into individual methods
- Ensure pagination test checks for cluster id on second page
    @o-nikolas
    o-nikolas authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d775f05 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merge branch 'main' into emr_paginate

    @o-nikolas
    o-nikolas authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    5f47e5d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into emr_paginate

    @o-nikolas
    o-nikolas authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    384e448 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into emr_paginate

    @o-nikolas
    o-nikolas authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    67d2ee2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into emr_paginate

    @o-nikolas
    o-nikolas authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    db686b8 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Update test_emr.py 

    Fix indent
    @o-nikolas
    o-nikolas authored May 1, 2023
    Configuration menu
    Copy the full SHA
    acab08f View commit details
    Browse the repository at this point in the history