Check DAG read permission before accessing DAG code #36257
Merged
+78
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ephraimbuddy,
pierrejeambrun,
kaxil,
XD-DENG and
ashb
as code owners
hussein-awala
commented
Dec 16, 2023
Comment on lines
-180
to
+186
| def code(cls, fileloc) -> str: | ||
| @provide_session | ||
| def code(cls, fileloc, session: Session = NEW_SESSION) -> str: | ||
| """Return source code for this DagCode object. | ||
| :return: source code as string | ||
| """ | ||
| return cls._get_code_from_db(fileloc) | ||
| return cls._get_code_from_db(fileloc, session) |
There was a problem hiding this comment.
This change is to avoid creating two different sessions because we use the method code and not the protected one.
potiuk
approved these changes
Dec 16, 2023
Taragolis
approved these changes
Dec 16, 2023
eladkal
approved these changes
Dec 16, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 30ea37e)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if the user has read access on the DAG before allowing the reading of the DAG code. If the DAG is defined with other DAGs in the same file, the user should have read access to all the other DAGs. Otherwise, he will be forbidden from reading the file code.