Use batch_is_authorized_dag to check if user has permission to read DAGs
#36279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
vincbeck
commented
Dec 18, 2023
| @@ -418,7 +418,7 @@ | |||
| "asgiref>=3.5.2", | |||
| "gcloud-aio-auth>=4.0.0,<5.0.0", | |||
| "gcloud-aio-bigquery>=6.1.2", | |||
| "gcloud-aio-storage", | |||
| "gcloud-aio-storage>=9.0.0", | |||
There was a problem hiding this comment.
No idea why this file has been modified
hussein-awala
approved these changes
Dec 18, 2023
hussein-awala
added
the
type:misc/internal
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
get_dag_source, it first fetch all accessible DAG ids for the current user and then check if the DAGs belong to these. It makes more sense to use the API made to figure out if a user has permission to access multiple DAGs:batch_is_authorized_dag.See #36257.
cc @hussein-awala
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.