Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dataset events above task/run details in grid view #37603

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

bbovenzi
Copy link
Contributor

Before, we had dataset events linked to a task instance or dag run below all of the details. It is too easy to miss that information, especially since those details contain a lot more information. Now all datasets are above all of the task/run metadata.

Also, broke up each section into its own component to keep our files smaller.

Before (scrolled to the bottom of the page):
Screenshot 2024-02-21 at 2 45 39 PM
Screenshot 2024-02-21 at 2 45 34 PM

After:
Screenshot 2024-02-21 at 2 45 12 PM
Screenshot 2024-02-21 at 2 45 15 PM

I think we can still improve the extra link and notes UI so they take up less vertical space.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Feb 21, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 21, 2024
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbovenzi
Nice work. is it feasible to add data set event extras?
Extras can be used to know about the additional details about the event.

@bbovenzi
Copy link
Contributor Author

@bbovenzi Nice work. is it feasible to add data set event extras? Extras can be used to know about the additional details about the event.

Sure. Updated!

@bbovenzi bbovenzi merged commit 3f8c0b9 into apache:main Feb 22, 2024
56 checks passed
@bbovenzi bbovenzi deleted the improve-task/run-dataset-event-ui branch February 22, 2024 18:26
sudiptob2 pushed a commit to Satoshi-Sh/airflow that referenced this pull request Feb 22, 2024
* Show dataset events above task/run details in grid view

* Add extra to dataset event tables
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants