Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dataset events above task/run details in grid view #37603

Merged
merged 2 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/static/js/api/useUpstreamDatasetEvents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function useUpstreamDatasetEvents({ runId }: Props) {
const upstreamEventsUrl = (
getMetaValue("upstream_dataset_events_api") ||
`api/v1/dags/${dagId}/dagRuns/_DAG_RUN_ID_/upstreamDatasetEvents`
).replace("_DAG_RUN_ID_", runId);
).replace("_DAG_RUN_ID_", encodeURIComponent(runId));
return axios.get<AxiosResponse, API.DatasetEventCollection>(
upstreamEventsUrl
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@
* under the License.
*/
import React, { useMemo } from "react";
import { Box, Heading, Text } from "@chakra-ui/react";
import { Box, Text } from "@chakra-ui/react";

import {
CodeCell,
DatasetLink,
Table,
TaskInstanceLink,
Expand Down Expand Up @@ -55,6 +56,12 @@ const DatasetTriggerEvents = ({ runId }: Props) => {
accessor: "timestamp",
Cell: TimeCell,
},
{
Header: "Extra",
accessor: "extra",
Cell: CodeCell,
disableSortBy: true,
},
],
[]
);
Expand All @@ -63,7 +70,9 @@ const DatasetTriggerEvents = ({ runId }: Props) => {

return (
<Box mt={3} flexGrow={1}>
<Heading size="md">Dataset Events</Heading>
<Text as="strong" mb={3}>
Dataset Events
</Text>
<Text>Dataset updates that triggered this DAG run.</Text>
<Table data={data} columns={columns} isLoading={isLoading} />
</Box>
Expand Down
193 changes: 193 additions & 0 deletions airflow/www/static/js/dag/details/dagRun/Details.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,193 @@
/*!
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React, { useEffect } from "react";
import {
Flex,
Box,
Button,
Spacer,
Table,
Tbody,
Tr,
Td,
useClipboard,
Text,
} from "@chakra-ui/react";

import ReactJson from "react-json-view";

import type { DagRun as DagRunType } from "src/types";
import { SimpleStatus } from "src/dag/StatusBox";
import { ClipboardText } from "src/components/Clipboard";
import { formatDuration, getDuration } from "src/datetime_utils";
import Time from "src/components/Time";
import RunTypeIcon from "src/components/RunTypeIcon";

interface Props {
run: DagRunType;
}

const formatConf = (conf: string | null | undefined): string => {
if (!conf) {
return "";
}
return JSON.stringify(JSON.parse(conf), null, 4);
};

const DagRunDetails = ({ run }: Props) => {
const { onCopy, setValue, hasCopied } = useClipboard(formatConf(run?.conf));

useEffect(() => {
setValue(formatConf(run?.conf));
}, [run, setValue]);

if (!run) return null;
const {
state,
runType,
lastSchedulingDecision,
dataIntervalStart,
dataIntervalEnd,
startDate,
endDate,
queuedAt,
externalTrigger,
conf,
confIsJson,
} = run;

return (
<Box mt={3} flexGrow={1}>
<Text as="strong" mb={3}>
Dag Run Details
</Text>
<Table variant="striped">
<Tbody>
<Tr>
<Td>Status</Td>
<Td>
<Flex>
<SimpleStatus state={state} mx={2} />
{state || "no status"}
</Flex>
</Td>
</Tr>
<Tr>
<Td>Run ID</Td>
<Td>
<ClipboardText value={run.runId} />
</Td>
</Tr>
<Tr>
<Td>Run type</Td>
<Td>
<RunTypeIcon runType={runType} />
{runType}
</Td>
</Tr>
{startDate && (
<Tr>
<Td>Run duration</Td>
<Td>{formatDuration(getDuration(startDate, endDate))}</Td>
</Tr>
)}
{lastSchedulingDecision && (
<Tr>
<Td>Last scheduling decision</Td>
<Td>
<Time dateTime={lastSchedulingDecision} />
</Td>
</Tr>
)}
{queuedAt && (
<Tr>
<Td>Queued at</Td>
<Td>
<Time dateTime={queuedAt} />
</Td>
</Tr>
)}
{startDate && (
<Tr>
<Td>Started</Td>
<Td>
<Time dateTime={startDate} />
</Td>
</Tr>
)}
{endDate && (
<Tr>
<Td>Ended</Td>
<Td>
<Time dateTime={endDate} />
</Td>
</Tr>
)}
{dataIntervalStart && dataIntervalEnd && (
<>
<Tr>
<Td>Data interval start</Td>
<Td>
<Time dateTime={dataIntervalStart} />
</Td>
</Tr>
<Tr>
<Td>Data interval end</Td>
<Td>
<Time dateTime={dataIntervalEnd} />
</Td>
</Tr>
</>
)}
<Tr>
<Td>Externally triggered</Td>
<Td>{externalTrigger ? "True" : "False"}</Td>
</Tr>
<Tr>
<Td>Run config</Td>
{confIsJson ? (
<Td>
<Flex>
<ReactJson
src={JSON.parse(conf ?? "")}
name={false}
theme="rjv-default"
iconStyle="triangle"
indentWidth={2}
displayDataTypes={false}
enableClipboard={false}
style={{ backgroundColor: "inherit" }}
/>
<Spacer />
<Button aria-label="Copy" onClick={onCopy}>
{hasCopied ? "Copied!" : "Copy"}
</Button>
</Flex>
</Td>
) : (
<Td>{conf ?? "None"}</Td>
)}
</Tr>
</Tbody>
</Table>
</Box>
);
};

export default DagRunDetails;
Loading