Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change f-string to formatting into the logging messages for Batch Executor #37929

Merged
merged 1 commit into from
Mar 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def sync(self):
if error_code in INVALID_CREDENTIALS_EXCEPTIONS:
self.IS_BOTO_CONNECTION_HEALTHY = False
self.log.warning(
f"AWS credentials are either missing or expired: {error}.\nRetrying connection"
"AWS credentials are either missing or expired: %s.\nRetrying connection", error
)
except Exception:
# We catch any and all exceptions because otherwise they would bubble
Expand Down Expand Up @@ -293,7 +293,8 @@ def attempt_submit_jobs(self):

if attempt_number >= int(self.__class__.MAX_SUBMIT_JOB_ATTEMPTS):
self.log.error(
f"This job has been unsuccessfully attempted too many times ({attempt_number}). Dropping the task."
"This job has been unsuccessfully attempted too many times (%s). Dropping the task.",
attempt_number,
)
self.fail(key=key)
else:
Expand Down