Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix built query with implicit cartessian product in AirflowSecurityManagerV2 #38913

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Taragolis
Copy link
Contributor

Found during analyse warnings from the #38905
In addition raise an error if this warning detected into the Airflow during tests run, same as proposed into the #28590, however it wasn't work before during the previous capture system which ignore all errors


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 10, 2024
@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label Apr 10, 2024
@Taragolis Taragolis closed this Apr 10, 2024
@Taragolis Taragolis reopened this Apr 10, 2024
@Taragolis Taragolis added the type:bug-fix Changelog: Bug Fixes label Apr 10, 2024
@Taragolis Taragolis added this to the Airflow 2.9.1 milestone Apr 10, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@uranusjr uranusjr merged commit e16dc0f into apache:main Apr 11, 2024
68 checks passed
@Taragolis Taragolis deleted the sa-detect-cartesian-product branch April 13, 2024 21:19
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
jedcunningham pushed a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit e16dc0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants