-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent volume claim retention policy #40271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
June 16, 2024 19:37
eladkal
changed the title
Retention policy
Add persistent volume claim retention policy
Jun 19, 2024
hussein-awala
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a small nit, otherwise LGTM
eladkal
approved these changes
Jun 19, 2024
amoghrajesh
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few nits, otherwise looks good @romsharon98
eladkal
force-pushed
the
retention-policy
branch
from
June 24, 2024 13:40
536cd6d
to
a2afc9e
Compare
utkarsharma2
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Jul 1, 2024
romsharon98
added a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* add persistentVolumeClaimRetentionPolicy * add new triggerer persistentVolumeClaimRetentionPolicy to values schema * add persistentVolumeClaimRetentionPolicy * revert pod-template-file * add description to values schema * add description to values.json * fix values-schema, imporove comments --------- Co-authored-by: Nir Rosenthal <nirr@perion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:helm-chart
Airflow Helm Chart
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #38361
Redo stale PR. Commits where cherry picked from stale PR to preserve credit to the origial author
cc: @nirroz93
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.