Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent volume claim retention policy #40271

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Jun 16, 2024

closes: #38361
Redo stale PR. Commits where cherry picked from stale PR to preserve credit to the origial author
cc: @nirroz93


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 16, 2024
@eladkal eladkal changed the title Retention policy Add persistent volume claim retention policy Jun 19, 2024
@eladkal eladkal requested a review from amoghrajesh June 19, 2024 02:15
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small nit, otherwise LGTM

chart/values.schema.json Outdated Show resolved Hide resolved
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few nits, otherwise looks good @romsharon98

chart/values.schema.json Outdated Show resolved Hide resolved
chart/values.schema.json Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
@eladkal eladkal merged commit ec09600 into apache:main Jun 25, 2024
66 checks passed
@eladkal eladkal added this to the Airflow Helm Chart 1.15.0 milestone Jun 25, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2024
romsharon98 added a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* add persistentVolumeClaimRetentionPolicy

* add new triggerer persistentVolumeClaimRetentionPolicy to values schema

* add persistentVolumeClaimRetentionPolicy

* revert pod-template-file

* add description to values schema

* add description to values.json

* fix values-schema, imporove comments

---------

Co-authored-by: Nir Rosenthal <nirr@perion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants